JSONAPI-Resources / JSONAPI-Resources/jsonapi-resources

Change ResourceIdentity <=> to take resource_klass into account when sorting.

Open
#1,429 0 comments 0 reactions 1 assignee View on GitHub

@lgebhardt is already working on this.

Since Jan 13, 2024.

Dominant language
Ruby
Stars
2.3k
Forks
546
PR merge metrics
No merged PRs in 30d

Description

This issue is a (choose one):

  • Problem/bug report.
  • Feature request.
  • Request for support. Note: Please try to avoid submitting issues for support requests. Use Gitter instead.

Checklist before submitting:

  • I've searched for an existing issue.
  • I've asked my question on Gitter and have not received a satisfactory answer.
  • I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
  • The feature I'm asking for is compliant with the JSON:API spec.

Description

I propose we compare the resource_klass.name first and then the ids. This would result in grouping of identities by type before ids. Since any sorting of these does not affect compliance with the spec I consider this a minor issue for polymorphic arrays of related identities.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.