JSONAPI-Resources / JSONAPI-Resources/jsonapi-resources
Repeating the same sort attribute with reverse direction overwrites the previous direction for that attribute
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 2.3k
- Forks
- 546
- PR merge metrics
- No merged PRs in 30d
Description
This issue is a (choose one):
- Problem/bug report.
Checklist before submitting:
- I've searched for an existing issue.
- I've asked my question on Gitter and have not received a satisfactory answer.
- I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
- The feature I'm asking for is compliant with the JSON:API spec.
Description
So, this is a pretty slim edge case. It concerns repetition of an attribute in the sort param, which can yield some arguably weird results that are possibly not compliant with the JSON:API spec recommendations:
Sort fields SHOULD be applied in the order specified.
Scenario
The index of a resource is called with a sort param, where the same attribute occurs more than once with different directions:
GET /foos?sort=bar,baz,-bar
Expected outcome
The records are ordered as specified by all the sort params, with an order of precedence from left to right. Any repetitions of the same attribute can be ignored, since they won't make a difference.
ORDER BY `foos`.`bar` ASC, `foos`.`baz` ASC, `foos`.`bar` DESC
or, equivalently, ignoring the repeated attributes:
ORDER BY `foos`.`bar` ASC, `foos`.`baz` ASC
Actual outcome
Whenever a sort attribute is repeated, its direction overwrites the previous direction of that same attribute.
ORDER BY `foos`.`bar` DESC, `foos`.`baz` ASC
Since ActiveRecord's order uses keyword arguments, calling it with repeated arguments will result in the repeated value overwriting the original value (with a warning). So it could be argued that the present behavior is consistent with how ActiveRecord works.
However, considering sort order in a more general sense or in the context of an SQL query it seems reasonable to me that a repeating value should not overwrite the original value.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing GET /foos?sort=bar,baz,-bar and inspect how the resource index sorting is passed to ActiveRecord's order method. Confirm that the first direction for a repeated attribute is preserved, then verify the generated ORDER BY behavior against the expected precedence described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby, sql
- Domain
- api, backend, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100