JGMEYER / JGMEYER/example-unity-project

[General] Find better way to track key names for IPlayerControls

Open
#42 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code cleanup
Dominant language
C#
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Ok, so this needs some explaining. In PlayerKeyboardControls, for example, you return the state of a player join button in the methods, then separately return its name in another method. That means you have to update both the state and name methods whenever you change which type of input controls what game flow. PlayerJoystickControls is even worse in that there is no defined mapping from, say Button0 to a nameable value on the controller (i.e. "(A) Button").

Figure out a way to, say, set "Player Join" button for a keyboard/joystick control where we could cleanly get the name for the assigned button.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading PlayerKeyboardControls and PlayerJoystickControls, focusing on the methods that separately provide button state and button names. Define completion as a single, consistent mapping that identifies the assigned Player Join control and provides its display name for both keyboard and joystick inputs.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, unity
Domain
game-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.