Ironclad / Ironclad/rivet

[Bug]: Half of the items are being lost in loops if the final output is not passed over to the next iteration

Open
#441 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
4.7k
Forks
388
PR merge metrics
No merged PRs in 30d

Description

### What happened?

Here is a simple graph that loads a dataset and gets one item from it in each iteration
image
After all iterations, the subgraph call has 54 outputs, while the next node after it has only 27.

image

If we check the execution iteration 2, it is clear that the input of text node does not match the output of the subgraph.
Connecting the text output to the loop data property and adding a break node temporary fixes this issue

### What was the expected functionality?

Input values should match the output values of the nodes they're connected to, when data is transferred between nodes

### Describe your environment

MacOS sonoma 14.4.1, Rivet version: app-v1.8.0

### Relevant log output

_No response_

### Relevant screenshots

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.