Ironclad / Ironclad/rivet

[Bug]: Read Directory node: glob and exclude don't work on windows

Open
#304 2 comments 0 reactions 0 assignees View on GitHub
bug good first issue
Dominant language
TypeScript
Stars
4.7k
Forks
388
PR merge metrics
No merged PRs in 30d

Description

### What happened?

In the Read Directory node, filter glob and excludes don't seem to work properly on Windows?

For example, if I enter `**/*.php` into filter glob, and `**/vendor/**/*` into excludes, the result includes everything from the `vendor` folder just the same.

I also tried using filter globs without excludes, instead using filter globs such as `**/app/**/*.php` - the produces no results.

I suspect maybe the backslashes in Windows paths is throwing off whatever implements glob support?

### What was the expected functionality?

Filter and exclude globs should work.

### Describe your environment

Windows 11 Pro

### Relevant log output

_No response_

### Relevant screenshots

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Research direction

Start with the Read Directory node and locate the implementation of its filter glob and exclude handling. Reproduce the examples on Windows 11, then inspect how Windows path separators are passed to glob matching; done means the PHP filter and vendor exclusion produce the expected results.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.