Ironclad / Ironclad/rivet

[Bug]: FS - Shell Command doesn't handle ".." path

Open
#225 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
4.7k
Forks
388
PR merge metrics
No merged PRs in 30d

Description

### What happened?

Shell Command node failed to resolve a valid path containing `..`.

### What was the expected functionality?

Valid shell path woudl be handled as in any normal shell.
The same command works with default WIndows shell (not PowerShell or some such).

### Describe your environment

Windows 11, default command prompt
`cp` comes from Git Bash installation.

### Relevant log output

_No response_

### Relevant screenshots

![image](https://github.com/Ironclad/rivet/assets/2566990/574f419a-3460-45fc-954d-fec7191b70d1)

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Research direction

Start at the Shell Command node entry point and reproduce the reported Windows 11 case with a valid path containing `..`, using the default command prompt and `cp` from Git Bash. Trace how that path is handled and verify the command succeeds as it does in a normal shell.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell, typescript
Domain
cli, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.