IronLanguages / IronLanguages/ironpython3

urllib.parse.urlsplit not raising a ValueError for certain characters

Open
#614 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Mono
Dominant language
C#
Stars
2.8k
Forks
316
Avg merge
1d 9h
Merged PRs (30d)
1

Description

The following characters are not raising a ValueError on Mono. This is causing a failure in test_urlparse.

import urllib.parse
for c in ("\ufe13", "\ufe16", "\ufe5f"):
    try:
        urllib.parse.urlsplit("http://netloc{}false.netloc/path".format(c))
        assert False
    except ValueError:
        pass

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the failing test_urlparse case under Mono and locate the urllib.parse.urlsplit implementation used by IronPython. Check why the characters \ufe13, \ufe16, and \ufe5f do not trigger ValueError for the shown netloc, then verify that the test passes with the expected exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.