IronLanguages / IronLanguages/ironpython3
Equality between bytes/bytearray and Array[Byte]/List[Byte] no longer works
Open
Nobody has claimed this yet.
.NET interop
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 316
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 1
Description
https://github.com/IronLanguages/ironpython3/pull/567 broke the following interop scenarios:
b = bytes(range(5))
System.Array[System.Byte](b) == b
System.Collections.Generic.List[System.Byte](b) == b
System.Array[System.Byte](b) == bytearray(b)
System.Collections.Generic.List[System.Byte](b) == bytearray(b)
While during initial development this is probably good (to help discover bugs) it might be worth enabling this scenario in the future.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request #567 and the equality behavior involved in IronPython's .NET interop. Reproduce the four examples from the issue, then identify the relevant implementation and tests. Done means Array[Byte] and List[Byte] comparisons work with both bytes and bytearray as shown.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, python
- Domain
- backend, compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100