IronLanguages / IronLanguages/ironpython3

LocalsDictionary not generated in certain cases

Open
#562 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core
Dominant language
C#
Stars
2.8k
Forks
316
Avg merge
1d 9h
Merged PRs (30d)
1

Description

a = locals
def test():
    return a()

assert test() == {}

It looks like there's an optimization to only create a locals dictionary when needed. However the way it determines if it's needed is by looking at the name of the call expression (see IronPython.Compiler.Ast.CallExpression.NeedsLocalsDictionary). NeedsLocalsDictionary returns false in the example above.

Similarly this will also fail for dir, vars, eval and exec...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproducer and inspect IronPython.Compiler.Ast.CallExpression.NeedsLocalsDictionary, especially how it identifies calls to locals, dir, vars, eval, and exec. Done means the shown indirect-call cases produce the expected behavior rather than failing because the locals dictionary was not generated.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, python
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.