IronLanguages / IronLanguages/ironpython3
System.Array ordering comparisons are not working
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 316
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 1
Description
System.Array ordering comparisons are raising a SystemError.
For example:
import System
assert System.Array[System.Int32]([0]) < System.Array[System.Int32]([1])
currently raises
SystemError: Compare
Note that this used to work in 2.7. At the very least it, if we don't want to support it, it should be raising a TypeError.
Also, trying to compare arrays of different lengths we get a ValueError:
import System
System.Array[System.Int32]([0]) < System.Array[System.Int32]([1,2])
ValueError: Object is not a array with the same number of elements as the array to compare it to.
Parameter name: other
I'm guessing this error comes from the .NET comparison? Probably preferable to not throw if we're going to be supporting ordering comparisons.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing both System.Array comparison examples and inspect the array comparison implementation and related tests. Determine the intended behavior for equal and different-length arrays, then add regression coverage showing that comparisons no longer raise the reported SystemError or ValueError and match the chosen semantics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100