IronLanguages / IronLanguages/ironpython3

test_int.test_instance_set failing on .NET 7

Open
#1,485 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

.NET 7
Dominant language
C#
Stars
2.8k
Forks
316
Avg merge
1d 9h
Merged PRs (30d)
1

Description

.NET 7 adds a number of new methods and properties to Int32 which are not available on BigInteger: TrailingZeroCount, Log2, MinMagnitude, PopCount, TryCreate, CreateSaturating, CreateTruncating, LeadingZeroCount, MaxMagnitude, CreateChecked, WriteLittleEndian, IsPow2, CopySign, IsNegative, Clamp, TryWriteLittleEndian, RotateLeft, RotateRight, GetShortestBitLength.

@BCSharp I guess we don't care about Int32 instances having additional members and we can just relax the assertion?

Related to https://github.com/IronLanguages/ironpython3/pull/1399.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the test_int.test_instance_set test named in the issue and inspect the assertion that compares Int32 and BigInteger members. Review the related pull request #1399 for context, then verify the test passes on .NET 7 while preserving the intended member-set checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, python
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.