IronLanguages / IronLanguages/ironpython3
returning NotImplemented from __radd__ does not work as expected
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 316
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 1
Description
For example:
called = [False]
class test(int):
def __radd__(self, other):
called[0] = True
return NotImplemented
assert 1 + test() == 1 # throws with ipy
assert called[0]
Similar to https://github.com/IronLanguages/ironpython3/issues/560. See also https://github.com/IronLanguages/ironpython3/pull/1478.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Run the Python reproduction in the issue and compare the behavior with issue 560 and pull request 1478. Trace the IronPython implementation of reflected addition and verify that returning NotImplemented allows the fallback result, with both assertions passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, python
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100