IronLanguages / IronLanguages/ironpython3
Incorrect usage of `Converter.TryConvertToString`?
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 316
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 1
Description
It looks like Converter.TryConvertToString converts user defined types to strings if they define __str__. I have no idea is this is the correct behaviour for this method? This causes some things to "work" when they probably shouldn't. For example:
class notstr:
def __str__(self):
return "test"
try:
"".join([notstr()])
assert False
except TypeError:
pass
try:
class test:
__slots__ = [notstr()]
assert False
except TypeError as e:
pass
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin at Converter.TryConvertToString and reproduce the two Python examples from the issue. The intended behavior is not specified, so confirm whether user-defined str conversions should be accepted before changing anything; done means the method and both examples consistently follow the decided semantics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, python
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100