IronLanguages / IronLanguages/ironpython3

socket.detach implementation has issues

Open
#1,224 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

module-socket
Dominant language
C#
Stars
2.8k
Forks
316
Avg merge
1d 9h
Merged PRs (30d)
1

Description

The socket.detach implementation sets the underlying C# socket to null, but none of the code is set up to deal with it, this causes most methods to fail with SystemError. For example:

import _socket
s = _socket.socket()
s.detach()
assert s.fileno() == -1

fails with:

SystemError: Object reference not set to an instance of an object.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the socket.detach implementation and trace methods that access the underlying C# socket after it is set to null. Reproduce the issue with the Python example in the report, then verify that detached sockets return -1 from fileno() without raising SystemError in the affected methods.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, python
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.