IronLanguages / IronLanguages/ironpython3

Derived exceptions not caught by C#

Open
#1,012 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core
Dominant language
C#
Stars
2.8k
Forks
316
Avg merge
1d 9h
Merged PRs (30d)
1

Description

For example:

class Test(SystemExit): pass

raise Test

does not terminate the process. The C# code expects a SystemExitException but the exception ends up being of type Exception.

Also, an IndexError (which becomes an IndexOutOfRangeException) would not be caught by LookupException handler in C# even though LookupError is a base of IndexError. For example:

try {
    PythonCalls.Call(context, somethingthatthrowsindexerror);
} catch (LookupException e) {
    // do stuff
}

would not catch the exception.

This came up in https://github.com/IronLanguages/ironpython3/pull/1011.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the exception conversion around PythonCalls.Call and the C# SystemExitException and LookupException handlers; no source file or test is named in the issue. Reproduce the provided derived SystemExit and IndexError examples, then verify that the corresponding C# handlers catch them according to the Python inheritance hierarchy.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.