IronLanguages / IronLanguages/ironpython3
attribute dict of _io._IOBase and of user-defined subclasses are not the same
Open
Nobody has claimed this yet.
module-io
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 316
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 1
Description
https://github.com/IronLanguages/ironpython3/pull/1000 adds __dict__ to _io._IOBase but it exposes the following issue:
import _io
b = _io.BytesIO()
b.foo = 2
assert "foo" in dir(b) # this currently fails
assert "foo" in b.__dict__
class Test(_io.BytesIO): pass
b = Test()
b.foo = 2
assert "foo" in dir(b)
assert "foo" in b.__dict__ # this currently fails
This causes pickling failures in CPython.test_memoryio.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the _io._IOBase and user-defined _io.BytesIO subclass behavior shown in the reproducer, then run CPython.test_memoryio to observe the related pickling failure. Done means the listed dir() and dict assertions pass for both objects and CPython.test_memoryio no longer fails.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100