IronCoreLabs / IronCoreLabs/ironoxide

`GroupGetResult` has redundant types

Open
#269 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
12
Forks
3
Avg merge
5h 4m
Merged PRs (30d)
3

Description

![image](https://user-images.githubusercontent.com/1424117/173443098-a55e5808-9177-451e-b9aa-8273e1043398.png)

Seems like `Option>` is just `Vec` with extra steps. Is there information communicated by `None` that isn't communicated by `[ ]`? If so, we should document that. If not, we should improve the interface so you don't have to check for both `None` and `.len() > 0` when using it.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating `GroupGetResult` and tracing how callers distinguish `None` from an empty `Vec`. Determine whether the two states communicate different information, then document that behavior or propose a simpler interface and update the affected callers and tests. No file or test paths are named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, cryptography
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.