IronCoreLabs / IronCoreLabs/ironoxide

Provide better error message for incorrect password

Open
#115 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
12
Forks
3
Avg merge
5h 4m
Merged PRs (30d)
3

Description

Currently the error for generating a new device with an incorrect password is `IronOxideErr::AesError(Unspecified)`. This comes from `ring::aead::OpeningKey.open_in_place()` for the decrypt case, but it comes from other places as well (like `encrypt_user_master_key()`).

We should make a better error message for these failure cases.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the incorrect-password path through ring::aead::OpeningKey.open_in_place() and the other failure paths mentioned, including encrypt_user_master_key(). Identify how IronOxideErr::AesError(Unspecified) is produced, then add a more useful error message for these cases and verify the affected error behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cryptography
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.