Irev-Dev / Irev-Dev/cadhub

Add tests for `menuConfig` to ensure no keyboard shortcuts overlap with Monaco editor shortcuts

Open
#499 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
384
Forks
58
PR merge metrics
No merged PRs in 30d

Description

We have implemented a solution for adding keyboard shortcuts to menu items using HotKeyJS, but have run into a possible issue where the editor package, Monaco Editor by Microsoft, has a large number of its own shortcuts that could interfere with our custom ones.

We would like to write a test that pulls either dynamically (preferred) or statically from a list of all of Monaco's command shortcuts to verify that any shortcuts defined within `menuConfig` are not already taken by the editor.

**Issues to solve:**
1. Monaco has no clean API to gather all command shortcuts
2. The syntax Monaco uses for defining shortcuts is different from HotKeyJS

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.