Ionaru / Ionaru/easy-markdown-editor

Split up toolbar button and icon classes

Open
#57 0 comments 0 reactions 0 assignees View on GitHub
Improvement
Dominant language
JavaScript
Stars
3.1k
Forks
363
PR merge metrics
No merged PRs in 30d

Description

### I'm submitting a...
- [ ] Bug report
- [x] Feature request

While working on #41 I noticed it is necessary define button classes and icon classes in the same field, this is a result of changes made to have FontAwesome 5 compatibility.

This behaviour is confusing for developers working with the editor and error prone because the editor has to figure out which classes to add to the icon and which ones to add to the button.

I want to mark `className` as deprecated and introduce `iconClass` and `buttonClass`, those fields combined will facilitate the same functionality.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.