Ionaru / Ionaru/easy-markdown-editor

Link toggle doesn't work as expected

Open
#534 0 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
JavaScript
Stars
3.1k
Forks
363
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Link toolbar button does not seem to toggle very well. Check the image bellow, it should give you an idea about the problem.

**To Reproduce**
Steps to reproduce the behavior:
1. Select some text to make into a link
2. Click on the link button in the toolbar
3. Now click again to toggle and remove the link
4. Observe that it functions incorrectly

**Expected behavior**
Adding and removing links should be seamless, the same way as you do in most markdown editing environments

**Screenshots**
![2023-02-25 16 24 05](https://user-images.githubusercontent.com/14940633/221362142-079a5aa3-cdf3-45cc-883e-df7812d32a54.gif)

**Version information**
- OS: macOS
- Browser: Safari, latest
- EasyMDE version: Default, latest

**Additional context**
Great work on this editor, keep it up.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the link-toolbar behavior in EasyMDE using the listed steps, especially on Safari. Trace the toolbar link action and confirm that selecting linked text, clicking the button, and clicking it again adds and removes the link seamlessly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.