Ionaru / Ionaru/easy-markdown-editor
maxHeight vs better flex Layout
- Dominant language
- JavaScript
- Stars
- 3.1k
- Forks
- 363
- PR merge metrics
- No merged PRs in 30d
Description
**Describe your question**
I wonder wahts the reasoning of doing
.EasyMDEContainer {
flex-direction: row,
flex-warp: wrap
}
and then having all the elements underneath each other.
Wouldn't it be easier to represent the layout as an actual flex layout instead of dealing with the warping.
The main reason i'm asking is im having trouble that the editor fills its parent container correctly.
If I do anthing like height:100% the footer will be just outside of the parent. And maxHeight property will need to be an absolute value which is not too great because I will need to handle the calculation of the max height dynamicly.
Contributor guide
Research direction
No file or test is named in the issue. Start by locating the EasyMDEContainer layout styles and the maxHeight handling, then compare the current wrapping behavior with the proposed column-and-row structure. Done should mean the editor, preview, toolbar, and footer fit their parent without requiring a fixed absolute maxHeight.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100