IntersectMBO / IntersectMBO/ouroboros-network

Enhance tx-submission test

Open
#5,327 0 comments 0 reactions 1 assignee Claimed by @crocodile-dentist View on GitHub
testing tx-submission
Dominant language
Haskell
Stars
296
Forks
104
Avg merge
2d 10h
Merged PRs (30d)
4

Description

It's worth adding a test that captures properties of txsToMempool in Test.Ouroboros.Network.TxSubmission.TxLogic module:

txsToMempool contains only downloaded txs
txsToMempool is disjoint from unacknowledgedTxIds after the decision is taken
The diff between previous txsToMempool and the new one is a subset of the intersection acknowledgedTxIds ∩ downloadedTxs \ bufferedTxs (it's more fine-grained than 1., but requires multiple decisions to be made).
It's easier to analyse a failing property like that than a whole simulation. These tests might come in handy when we start making bigger changes to the tx-logic.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.