IntersectMBO / IntersectMBO/ouroboros-network

Refactor `peerMonitoringLoop` and outbound governor `deactivatePeerConnection` calls

Open
#4,767 1 comment 0 reactions 0 assignees View on GitHub
outbound-governor peer-state-actions
Dominant language
Haskell
Stars
296
Forks
104
Avg merge
2d 10h
Merged PRs (30d)
4

Description

- The `deactivatePeerConnection` function is currently employed in two contexts, both responsible for mux termination. However, mux termination should be exclusively handled by the `peerMonitoringLoop` upon detecting a `Hot -> Cold` demotion.
- The role of `deactivatePeerConnection` in the outbound-governor should be limited to waiting for the termination of all hot mini-protocols and then either returning or throwing an exception.
- Some refactoring is recommended to streamline these processes and prevent similar issues in the future.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.