IntersectMBO / IntersectMBO/ouroboros-network

Don't use retry as a missing value in P2P

Open
#4,747 0 comments 0 reactions 0 assignees View on GitHub
high-priority ouroboros-diffusion outbound-governor technical debt
Dominant language
Haskell
Stars
296
Forks
104
Avg merge
2d 10h
Merged PRs (30d)
4

Description

[Here](https://github.com/input-output-hk/ouroboros-network/blob/65c14fac1d1aca1fdad7a9ba86a790824cebb349/ouroboros-network/src/Ouroboros/Network/Diffusion/P2P.hs#L1055) we pass `retry` as a substitution for a missing action. It would be more sensible to pass `Maybe (STM ...)` and let the layer below decide what to do when the action is not given.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.