IntersectMBO / IntersectMBO/ouroboros-network

Implement a nice `HasTextFormatter` instance for `PeerSelectionActionsTrace`

Open
#4,164 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
296
Forks
104
Avg merge
2d 10h
Merged PRs (30d)
4

Description

Currently `cardano-node` implements the `HasTextFormatter` as an orphan instance using `show`, which clutters up the logs with unnecessary information. It would be great if that instance was implemented in the network code where it's possible to get all of the information out of the value and format the information nicely.

@Jimbo4350 wants to have this in the 1.35.0 release of node (see [this discussion](https://github.com/input-output-hk/cardano-node/pull/4608/files#r1025260625)), so it might be a good idea to add it to #4144.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.