IntersectMBO / IntersectMBO/ouroboros-network

Simplify conditions in sendBuf and recvBuf

Open
#1,842 0 comments 0 reactions 0 assignees View on GitHub
Windows
Dominant language
Haskell
Stars
296
Forks
104
Avg merge
2d 10h
Merged PRs (30d)
4

Description

`System.Win32.Async.Socket.recvBuf` always logs `result, errorCode`:
```
recvBuf -1, 997
recvBuf -1, 997
recvBuf -1, 997
recvBuf -1, 997
recvBuf 0, 0
recvBuf 0, 0
recvBuf -1, 997
```

`System.Win32.Async.Socket.sendBuf` always logs `result, errorCode`:
```
sendBuf 0, 0
sendBuf 0, 0
sendBuf 0, 0
sendBuf 0, 0
sendBuf 0, 0
sendBuf -1, 997
sendBuf 0, 0
sendBuf 0, 0
sendBuf 0, 0
sendBuf 0, 0
```

This suggest they agree on error so we could just decide on one of them.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.