IntersectMBO / IntersectMBO/ouroboros-consensus

Take version into account in nodeBlockFetchSize

Open
#653 0 comments 0 reactions 0 assignees View on GitHub
technical debt
Dominant language
Haskell
Stars
67
Forks
43
Avg merge
5d 13h
Merged PRs (30d)
43

Description

Currently, `nodeBlockFetchSize` does not take the `BlockNodeToNodeVersion` (it's not used for `NodeToClient` protocols at the moment) into account when coming up with an estimate for the block size. This means that if for a certain version, the blocks are larger, `nodeBlockFetchSize` would have to overestimate for the other versions, just to make sure that it never underestimates.

Note that eventually `nodeBlockFetchSize` should be removed from `RunNode`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.