IntersectMBO / IntersectMBO/ouroboros-consensus

ChainSyncServer: report a tip consistent with the instruction

Open
#636 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
67
Forks
43
Avg merge
5d 13h
Merged PRs (30d)
43

Description

When the ChainSyncServer sends an instruction to a client, it also includes the tip of the current chain. However, this tip is currently not guaranteed to be consistent with the instruction:
https://github.com/input-output-hk/ouroboros-network/blob/6ca4a5262f999f7624aee61074203d9e735ce12b/ouroboros-consensus/src/Ouroboros/Consensus/MiniProtocol/ChainSync/Server.hs#L103-L105

Quoting @dcoutts:
> [this could lead to] e.g. [a] situation where we tell a client to roll forward, but the node is concurrently rolling back and the tip we report has an earlier block number than the block or header we're serving. It's just odd. Not that things should be relying on it much.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.