IntersectMBO / IntersectMBO/ouroboros-consensus

Re-enable Shelley TxGen

Open
#632 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
67
Forks
43
Avg merge
5d 13h
Merged PRs (30d)
43

Description

In https://github.com/input-output-hk/ouroboros-network/pull/2681 we disabled the TxGen for Shelley, see the PR in question for why.

We must not forget to re-enable it. Note that https://github.com/input-output-hk/cardano-ledger-specs/pull/1929 sped up the generator by 2x, but that's not enough to compensate for the 10x slow down.

---

We recently found a thunk in the `Likelihood` type in the ledger, see https://github.com/input-output-hk/cardano-ledger-specs/pull/1967. I could *not* find the thunk by running the Shelley ThreadNet tests with the nothunks check on (enable `checktvarinvariant` for `io-sim-classes`). I believe this is because we don't generate transactions anymore.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.