IntersectMBO / IntersectMBO/ouroboros-consensus

Try to remove dbBlocks from module Test.Ouroboros.Storage.LedgerDB.OnDisk

Open
#573 0 comments 0 reactions 0 assignees View on GitHub
technical debt
Dominant language
Haskell
Stars
67
Forks
43
Avg merge
5d 13h
Merged PRs (30d)
43

Description

While working on https://github.com/input-output-hk/ouroboros-network/pull/3610 we discovered a problem where it is possible to change the current chain to contain blocks with invalid payload after performing a switch command in the tests of Test.Ouroboros.Storage.LedgerDB.OnDisk. See:

```
dbBlocks: { (hash 0, slot 0) -> valid }
dbState : [ (hash 0, slot 0), LedgerDB valid ]

Switch [ Block (hash 0) (slot 0) invalid ]

dbBlocks: { (hash 0, slot 0) -> invalid }
dbState : [ (hash 0, slot 0), LedgerDB valid ]
```

This task is about analyzing whether dbBlocks can be removed and if so, removing it. If it cannot be removed, then we need to document the reasons why.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.