IntersectMBO / IntersectMBO/ouroboros-consensus
More exhaustive golden tests for Node-to-Client queries
- Dominant language
- Haskell
- Stars
- 67
- Forks
- 43
- Avg merge
- 5d 13h
- Merged PRs (30d)
- 43
Description
Currently, we have golden tests for some, but not all queries (both the encoded query and result messages):
https://github.com/IntersectMBO/ouroboros-consensus/blob/15d2e93a44cf9697d99634695e67c685540410da/ouroboros-consensus-cardano/src/shelley-testlib/Test/Consensus/Shelley/Examples.hs#L199-L217
The goal of this ticket is to extend this:
- Add golden tests for all queries, which also includes adding necessary examples for ledger types to Ledger.
- Make sure that the existing examples are sufficiently interesting; e.g. the example `PoolDistr` used for `GetStakeDistribution` has only one entry, which means that we couldn't notice that a recent Ledger update changed the encoding for maps with more than 23 elements.
- Add regressions specific to PR #922: check that Conway queries are decoder failures for era before Conway.
Contributor guide
Assessment
This issue has not been assessed yet.