IntersectMBO / IntersectMBO/ouroboros-consensus

Genesis test failure: restarting the mocked node is too slow

Open
#1,450 0 comments 0 reactions 0 assignees View on GitHub
Genesis
Dominant language
Haskell
Stars
67
Forks
43
Avg merge
5d 13h
Merged PRs (30d)
43

Description

The "hopefully" and the "promptly" in this comment https://github.com/IntersectMBO/ouroboros-consensus/blob/da502c2c4d73ea177af3ab7a9630beafae4b7c6c/ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/PeerSimulator/NodeLifecycle.hs#L205 are incorrect.

```
$ git lg -1
99e49deff - (HEAD, origin/main, origin/HEAD) Add version `0.5` and its publishing date to the `utxo-db-api` doc (#1438) (21 hours ago)
$ cabal run ouroboros-consensus-diffusion:test:consensus-test -- --quickcheck-tests=1 --quickcheck-replay='(SMGen 52839424461818769 12444177963069598431,2)' -p '/the node is shut down and restarted after some time/' --quickcheck-shrinks=10000000
```

Inspecting that trace, I see that the wall clock advances a lot while the node is restarting, and so the ticks' timestamps and the wall clock seem to be out of sync.

I didn't dig enough to know why that's happening or exactly why it's leading to the test failure, but it is already evidence of a problem with the implementation of that test.

(Clarification: it does not block the first release of Genesis as an experimental feature.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.