IntersectMBO / IntersectMBO/govtool

🐛 5G. Inconsistent Modal Display for "See External Data" on Different Screen Sizes

Open
#2,555 2 comments 0 reactions 2 assignees Claimed by @Ciabas View on GitHub
🌐 Post/After Plomin hard fork 🐛 Bug 🕵️‍♂️ Testing
Dominant language
HTML
Stars
21
Forks
29
Avg merge
2d 22h
Merged PRs (30d)
7

Description

### Area

Other

### Domain

dev-sanchogov.tools

### Which wallet were you using?

_No response_

### Context

When navigating to a governance action with incorrectly formatted data, clicking "See External Data" triggers a modal popup. On a desktop-sized screen, the modal displays a warning with the title "Be careful":

![image](https://github.com/user-attachments/assets/4121a9ea-8d2e-4133-811f-1976698f0185)

However, resizing the screen to a mobile view changes the modal to display a different title: "External Link Safety":

![image](https://github.com/user-attachments/assets/565574f6-c01e-48e1-83ae-76b8f40fca7f)

### Steps to reproduce

1. Navigate to [any governance action page with data formatted incorrectly](https://dev-sanchonet.govtool.byron.network/governance_actions/5aa1281078297e2623a382e28a6fee158e7dc40fd07b370d994cccbc0e461bdc#0).
2. Click on "See External Data".
3. Observe the modal with the title "Be careful".
4. Resize the screen to a mobile view.
5. Notice the modal title changes to "External Link Safety".

https://www.loom.com/share/d453cc5c386e4ffeb51093a60e310200?sid=21155d0e-7596-4c6b-8fca-906ac659a8f7

### Actual behavior

Two different modals are displayed for the same action depending on the screen size.

### Expected behavior

The same modal should be displayed regardless of screen size for the same action.

### Question
- Is this the intended behavior, or was it overlooked for smaller screens?

### Allure Report
- [5G. Should show warning in bad governance action proposal to the users to visit the site at their own risk, when external url is opened](https://intersectmbo.github.io/govtool-test-reports/govtool-frontend/241/#behaviors/1402987606cbaebad9beb98f5734b5ef/8192eb3e3e23fddf/)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.