IntersectMBO / IntersectMBO/formal-ledger-specifications

Missing fields from `StakePoolParams`

Open
#1,259 1 comment 0 reactions 0 assignees View on GitHub
bug era: shelley
Dominant language
Agda
Stars
52
Forks
20
Avg merge
6d 14h
Merged PRs (30d)
7

Description

We're missing a bunch of fields compared to the [implementation](https://github.com/IntersectMBO/cardano-ledger/blob/master/libs/cardano-ledger-core/src/Cardano/Ledger/State/StakePool.hs#L424). Since conformance tests didn't find any, this means these are either disabled or never generated?

I believe we are missing `id, vrf, relays` and `metadata`. I think `accountAddress` is our `rewardAccount` (matching with the fact that their `AccountAddress` type is just a newtype wrapped `Credential`.

When adding these, it would be good to check what kind of validation the implementation performs on these. Note that except for the `vrf`, all of these are also missing from the original Shelley spec.

Contributor guide

Open the contributing guide

Research direction

Compare StakePoolParams with the linked Cardano ledger implementation, then inspect the conformance tests and the original Shelley spec. Determine how id, vrf, relays, metadata, and accountAddress/rewardAccount map and what validation the implementation applies; done means the missing fields and their validation are represented consistently.

Written by the indexing model from the issue text.

Assessment

Domain
blockchain
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.