IntersectMBO / IntersectMBO/cardano-test-plans

Some thoughts - General conway tests, vote tests, derived keys tests

Open
#13 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Hey, i took a look at the current tests. Not sure whats already in planning, but just a few quick thoughts:

Shouldn't there be also tests for general changes in the conway era?

For example:
- StakeAddress registration/deregistration with the new format pointed out in the CDDL (https://github.com/input-output-hk/cardano-ledger/blob/bcf6051f4a0b69c82e4de7327d7d8801fa1bad87/eras/conway/impl/cddl-files/conway.cddl#L303-L304). Doing a check that it works like it should with the additional information about the depositAmount.
- Additional check if a StakeAddress has locked up a deposit in an action, can it be deregistered during that phase?

Also there are currently no **vote related tests** listed, which should also include all the new possible voteDelegation methods (https://github.com/input-output-hk/cardano-ledger/blob/bcf6051f4a0b69c82e4de7327d7d8801fa1bad87/eras/conway/impl/cddl-files/conway.cddl#L305-L309).

General tests on **thresholds** set via the genesis file, are they reached before executed/accepted?

Should there also be tests that the CLI accepts keys generated from 3rd party tools, but following the CIP105 (https://github.com/cardano-foundation/CIPs/tree/master/CIP-0105) key specifications? Which includes also derived keys like:
```json
{
"type": "DRepExtendedSigningKey_ed25519_bip32",
"description": "Delegate Representative Signing Key",
"cborHex": "5880b8edb7749cd800de5b05e66d04f961347402e18c3502200b2e725c68dd165c584c4d82337e82dbb8c624b3f6e81998e87a2de7b9994dca13e270fc33cf19e8c2f4208788c1a1a7cfd4dc08897d26ee6cd1833341381745dd9addd34c2526f7398070106390effad1043d37dbff4e8d985577f26905cc47f011bc48d2b96f0661"
}
{
"type": "DRepExtendedVerificationKey_ed25519_bip32",
"description": "Delegate Representative Verification Key",
"cborHex": "5840f4208788c1a1a7cfd4dc08897d26ee6cd1833341381745dd9addd34c2526f7398070106390effad1043d37dbff4e8d985577f26905cc47f011bc48d2b96f0661"
}
```
```json
{
"type": "ConstitutionalCommitteeColdExtendedSigningKey_ed25519_bip32",
"description": "Constitutional Committee Cold Extended Signing Key",
"cborHex": "5880f8dfdcb6d8df47e00526bd62d4ce7858259687634748fc20cf43782104680653a10bc6ea9c893bd3b9a65a1fb5ae8513904de30099d1a539d8eb5b8efa9e91d2f2826992bd42a69a0dbfc3646cb716e5c5dc5eda4c85cc7ae895dbb71b4e39385b5d19b651930efa706612d01f94d367f9858ee772863698aea9fa81e9f3f9ab"
}
{
"type": "ConstitutionalCommitteeColdExtendedVerificationKey_ed25519_bip32",
"description": "Constitutional Committee Cold Extended Verification Key",
"cborHex": "5840f2826992bd42a69a0dbfc3646cb716e5c5dc5eda4c85cc7ae895dbb71b4e39385b5d19b651930efa706612d01f94d367f9858ee772863698aea9fa81e9f3f9ab"
}
```
```json
{
"type": "ConstitutionalCommitteeHotExtendedSigningKey_ed25519_bip32",
"description": "Constitutional Committee Hot Extended Signing Key",
"cborHex": "588078f37a090551cb87b8b0ad610eac4bb6e2637caa61913118b7828e807d27b05b699bcb4b39be9a5e18caaf264d91e85be4677190b5200cfcca68083ea51854ff6bdd9399376a92ba691eb60c5a95283c815285e6784667958dcc246e2a631d544c00344da3e174c5082d4342d65f920eb36204057ce081147d75010773b4a412"
}
{
"type": "ConstitutionalCommitteeHotExtendedVerificationKey_ed25519_bip32",
"description": "Constitutional Committee Hot Extended Verification Key",
"cborHex": "58406bdd9399376a92ba691eb60c5a95283c815285e6784667958dcc246e2a631d544c00344da3e174c5082d4342d65f920eb36204057ce081147d75010773b4a412"
}
```

Should tests related to HW-Wallets and Conway things like dRep-Key generation, etc. also be included in the tests or is this out of scope because of 3rd party tools?

Best regards, Martin

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the Conway CDDL sections linked in the issue and the CIP-105 key specifications, then inspect the existing test plan structure and CLI or hardware-wallet coverage. Done would require an agreed scope and documented tests for Conway address deposits, vote delegation, thresholds, derived keys, and any in- or out-of-scope third-party wallet behavior.

Written by the indexing model from the issue text.

Assessment

Domain
blockchain, cli, testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.