IntersectMBO / IntersectMBO/cardano-ledger

CIP-23 Fair Min Fees

Open
#5,954 0 comments 0 reactions 0 assignees View on GitHub
DijkstraEra intra-era-hardfork
Dominant language
Haskell
Stars
295
Forks
179
Avg merge
4d 7h
Merged PRs (30d)
29

Description

This ticket is about utilizing the protocol parameter that was added in #5949

There is a slight deviation from the how the CIP-23 describes it, namely we will not fail update/registration of pools that specify margin that is lower than the one in the `ppMinPoolMargin`. However, during the reward calculation the maximum of declared margin and and value in above parameter will be used.

Same logic should be applied for the `cost` stake pool parameter and `ppMinPoolCost` protocol parameter, starting with Dijkstra era

Contributor guide

Open the contributing guide

Research direction

Start by reviewing CIP-23 and the protocol-parameter work in #5949, then trace the reward calculation and stake-pool parameter handling for the Dijkstra era. Confirm that declared margin and cost are not rejected when below their protocol minimums, but the higher value is used during reward calculation; add or update the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
blockchain
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.