IntersectMBO / IntersectMBO/cardano-ledger
Golden tests for `examplePParams` and `examplePParamsUpdate`
- Dominant language
- Haskell
- Stars
- 295
- Forks
- 179
- Avg merge
- 4d 7h
- Merged PRs (30d)
- 29
Description
Now that we have these properly defined examples we should use them to define JSON and CBOR golden tests in `ledgerEraTestMain`, which will allow us to remove these outdated tests:
https://github.com/IntersectMBO/cardano-ledger/blob/9cf0b8a0e329ee68752a7d01abab6bf92503a42d/libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/JSON.hs#L68-L85
Contributor guide
Research direction
Start with ledgerEraTestMain and the outdated tests in libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/JSON.hs, especially the referenced lines. Use examplePParams and examplePParamsUpdate as the basis for JSON and CBOR golden tests, then confirm the outdated tests can be removed and the test suite passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- haskell
- Domain
- blockchain, testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100