IntersectMBO / IntersectMBO/cardano-ledger

Move `ChainChecks` into tests

Open
#5,856 0 comments 0 reactions 0 assignees View on GitHub
:cake: good first issue :credit_card: technical-debt
Dominant language
Haskell
Stars
295
Forks
179
Avg merge
4d 21h
Merged PRs (30d)
30

Description

Thanks to integration done in https://github.com/IntersectMBO/ouroboros-consensus/pull/2043 we no longer need this module, since it was only needed for Consensus: https://github.com/IntersectMBO/cardano-ledger/blob/ebed62de1ebcd4b13512418d49d17802a193e2c1/eras/shelley/impl/src/Cardano/Ledger/Chain.hs

It is still needed for testing, so we should move it to the only place in ledger where it is actually used.

Contributor guide

Open the contributing guide

Research direction

Locate the ChainChecks module and identify the testing location where it is still used. Read that test area and verify the module is no longer needed by Consensus; move the module there, then run the relevant ledger test suite to confirm the tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.