IntersectMBO / IntersectMBO/cardano-ledger

Byron CDDLs are missing transaction encodings

Open
#5,124 0 comments 0 reactions 0 assignees View on GitHub
cddl
Dominant language
Haskell
Stars
295
Forks
179
Avg merge
4d 7h
Merged PRs (30d)
29

Description

At first I thought the `tx` type would be the transaction type in Byron, but it turns out it is not. The `GenTx` for Byron is in fact a:
```haskell
data AMempoolPayload a
= -- | A transaction payload (transaction and witness).
MempoolTx !(ATxAux a)
| -- | A delegation certificate payload.
MempoolDlg !(Delegation.ACertificate a)
| -- | An update proposal payload.
MempoolUpdateProposal !(Update.AProposal a)
| -- | An update vote payload.
MempoolUpdateVote !(Update.AVote a)
```

where each of the options has a different tag and contents. It would be necessary to add these definitions to the cddl file:

```cddl
transaction = [0, [byron.tx, [+ byron.twit]]] ; MempoolTx
/ [1, ...]
/ [2, ...]
/ [3, ...]
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.