IntersectMBO / IntersectMBO/cardano-coin-selection

Reuse `cardano-coin-selection` library within `cardano-wallet`.

Open
#20 0 comments 0 reactions 1 assignee Claimed by @jonathanknowles View on GitHub
Dominant language
Haskell
Stars
19
Forks
10
PR merge metrics
No merged PRs in 30d

Description

# Context

When the work to create a separate [**coin selection and fee balancing library**](https://github.com/input-output-hk/cardano-wallet/milestone/58) is complete, we'd like to be able to reuse the library internally within the [`cardano-wallet`](https://github.com/input-output-hk/cardano-wallet) library.

# Decision

Make the [`cardano-wallet` library](https://github.com/input-output-hk/cardano-wallet) depend upon the Hackage version of [`cardano-coin-selection`](https://github.com/input-output-hk/cardano-coin-selection), and remove all local copies of coin selection code.

# Acceptance Criteria

- [ ] The [`cardano-wallet`](https://github.com/input-output-hk/cardano-wallet) library **must** depend upon the Hackage version of [`cardano-coin-selection`](https://github.com/input-output-hk/cardano-coin-selection).

- [ ] The [`cardano-wallet`](https://github.com/input-output-hk/cardano-wallet) library **must not** duplicate code that is included within the published [`cardano-coin-selection`](https://github.com/input-output-hk/cardano-coin-selection) library.

- [ ] The [`cardano-wallet`](https://github.com/input-output-hk/cardano-wallet) library **must** continue to implement the algorithm fallback policy currently in place (Currently, this is from `Random-Improve` to `Largest-First`) and there **must** be tests in place to determine that this policy activates appropriately.

# Development

_Section to be added._

# QA

_Section to be added._

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.