IntersectMBO / IntersectMBO/cardano-cli

[MAINTENANCE] - Remove usages of `SafeHash`

Open
#952 8 comments 0 reactions 0 assignees View on GitHub
refactor Stale
Dominant language
Haskell
Stars
71
Forks
24
Avg merge
23h 40m
Merged PRs (30d)
14

Description

## What

Replace all usages of `SafeHash` with unverified `Hash` unless in cases where it is possible to track the source of the hash. If somewhere this is unavoidable, wait till the last second before unsafely converting to `SafeHash`.

## Why

`SafeHash` is meant to encode that the hash has a pre-image, but this is not enforceable most of the time in practice, since both `cardano-cli` and `cardano-api` are often provided with the hash only, not with the pre-image.

## Acceptance Criteria

- There are no unsafe creations of `SafeHash` with the possible exception of just before interfaces with modules down the stack if unavoidable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.