IntersectMBO / IntersectMBO/cardano-api

[FR] - `TxVotingProcedures` accepts `ScriptWitness` but not broader `Witness` type

Open
#722 13 comments 0 reactions 1 assignee Claimed by @carbolymer View on GitHub
Dominant language
Haskell
Stars
40
Forks
30
Avg merge
2d 5h
Merged PRs (30d)
30

Description

*External*

**Area**
Transaction building.

**Describe the feature you'd like**
Constructors such as `TxWithdrawals`, `TxCertificates` accepts `Witness` under `BuildTxWith` but [`TxVotingProcedures`](https://github.com/IntersectMBO/cardano-api/blob/9386533b1c9f5e262287d4cca6dbaad4d4365eec/cardano-api/internal/Cardano/Api/Tx/Body.hs#L1289) utilizes `ScriptWitness` which does not include key witnesses. Is this deliberate? Is it that key witnesses don't make sense in this context? If key witnesses make sense for voting procedures, then not including them may mess up with functions like `estimateTransactionKeyWitnessCount`.
Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.