InternLM / InternLM/xtuner

Citation for OpenRLHF in relation to the XTuner RLHF code and architecture

Open
#770 7 comments 8 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5.2k
Forks
448
Avg merge
3d 15h
Merged PRs (30d)
26

Description

Hi, XTuner Team

Could you please add a citation for the source of the Ray+vLLM-based RLHF architecture - OpenRLHF, such as in the README.md file: https://github.com/InternLM/xtuner?tab=readme-ov-file#%EF%B8%8F-acknowledgement.
**We noticed that most RLHF-related code, particularly the Ray RLHF architecture in XTuner, are refactored from OpenRLHF.** According to the Apache License 2.0 of OpenRLHF, the original copyright statement must be included.

An example:
```
XTuner's RLHF solution mainly references OpenRLHF, for which we are grateful.
```

Related MR:
https://github.com/InternLM/xtuner/pull/736
https://github.com/InternLM/xtuner/pull/764

Thank you

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.