IntelliTect / IntelliTect/CodingGuidelines

Flag Task.Delay(0) as being Task.CompletedTask

Open
#55 2 comments 0 reactions 0 assignees View on GitHub
enhancement Hacktoberfest
Dominant language
C#
Stars
12
Forks
16
Avg merge
2m
Merged PRs (30d)
7

Description

Task.Delay(0) is the same as Task.CompletedTask
[.NET Core](https://source.dot.net/#System.Private.CoreLib/shared/System/Threading/Tasks/Task.cs,5396)
[.NET Framework](https://referencesource.microsoft.com/#mscorlib/system/threading/Tasks/Task.cs,5881)

Test cases:
```
Task.Delay(0);
Task.Delay(0, token);
```

Suggest:
We should suggest changing to `Task.CompletedTask` since that is what is going to happen anyway.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.