IntellectualSites / IntellectualSites/PlotSquared

Could not pass event InventoryCloseEvent

Open
#4,865 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Requires Testing
Dominant language
Java
Stars
653
Forks
975
Avg merge
2m
Merged PRs (30d)
6

Description

Server Implementation

Paper

Server Version

1.21.11

Describe the bug

[11:52:55] [User Authenticator #138/INFO]: UUID of player xXS0UTHXx is a1e535ef-4dac-363e-b868-5ccba8f4b0f4

this player prob couldn't join & it caused that error:

[17:00:33] [Server thread/ERROR]: Could not pass event InventoryCloseEvent to PlotSquared v7.5.13-SNAPSHOT
com.plotsquared.core.util.PlayerManager$NoSuchPlayerException: There is no online player with UUID 'a1e535ef-4dac-363e-b868-5ccba8f4b0f4'
	at plotsquared-bukkit-7.5.13-SNAPSHOT.jar//com.plotsquared.bukkit.player.BukkitPlayerManager.getPlayer(BukkitPlayerManager.java:62) ~[?:?]
	at plotsquared-bukkit-7.5.13-SNAPSHOT.jar//com.plotsquared.bukkit.util.BukkitUtil.adapt(BukkitUtil.java:124) ~[?:?]
	at plotsquared-bukkit-7.5.13-SNAPSHOT.jar//com.plotsquared.bukkit.listener.PlayerEventListener.onInventoryClose(PlayerEventListener.java:1480) ~[?:?]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:71) ~[leaf-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:60) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:629) ~[leaf-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.event.CraftEventFactory.handleInventoryCloseEvent(CraftEventFactory.java:1636) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.level.ServerPlayer.closeContainer(ServerPlayer.java:2028) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at org.bukkit.craftbukkit.entity.CraftHumanEntity.closeInventory(CraftHumanEntity.java:597) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at org.bukkit.entity.HumanEntity.closeInventory(HumanEntity.java:309) ~[leaf-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604) ~[?:?]
	at org.bukkit.craftbukkit.inventory.CraftInventory.close(CraftInventory.java:486) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at opencreative-6.0.0-build-254.jar//ua.mcchickenstudio.opencreative.menus.Menus$1.run(Menus.java:62) ~[?:?]
	at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:78) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:474) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1881) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1713) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:492) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.MinecraftServer.processPacketsAndTick(MinecraftServer.java:1770) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1434) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:430) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?]

and spammed a few hours

To Reproduce

Not really sure, player tried to join, and then the error started appearing after a few mins, spamming till restart.

Expected behaviour

No error

Screenshots / Videos

No response

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/76a68dcdf7cb4d7e8e9d2b267756fa7b

PlotSquared Version

7.5.13-SNAPSHOT

Checklist
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at PlayerEventListener.java:1480 in onInventoryClose, then follow BukkitUtil.java:124 and BukkitPlayerManager.java:62 where the missing online player is reported. Investigate how an InventoryCloseEvent can reference the UUID of a player who failed to join, using the supplied debugpaste and stack trace. Done means this scenario no longer produces repeated errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.