IntellectualSites / IntellectualSites/PlotSquared

Players can bypass plot protection by using buckets on use-allowed blocks

Open
#4,851 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Approved Bug
Dominant language
Java
Stars
653
Forks
975
Avg merge
2m
Merged PRs (30d)
6

Description

Server Implementation

Paper

Server Version

1.21.11

Describe the bug

See video

To Reproduce
  1. Set a use flag that accepts blocks able to be flooded with liquid (e.g. levers)
  2. While holding a filled bucket, shift-right-click on a use-flag interactable block such that it would be placed in the foldable use-flag block
Expected behaviour

Unadded players to not be able to empty liquids on a plot

Screenshots / Videos

https://github.com/user-attachments/assets/a642b5fc-6902-4985-9d04-b940ff669803

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/7abb0398dbe14adc9b8b0358b6d60029

PlotSquared Version

7.5.13-SNAPSHOT

Checklist
Anything else?

Line: https://github.com/IntellectualSites/PlotSquared/blob/dd66c6815a35a671fa14fa1fe57ab4b1970e1c6f/Bukkit/src/main/java/com/plotsquared/bukkit/listener/PlayerEventListener.java#L1426

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Bukkit/src/main/java/com/plotsquared/bukkit/listener/PlayerEventListener.java around line 1426 and reproduce the bucket interaction using the listed steps on PlotSquared 7.5.13-SNAPSHOT. Trace how use-allowed blocks and filled buckets are handled, then verify that unadded players cannot empty liquids on a plot while allowed interactions still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.