IntellectualSites / IntellectualSites/PlotSquared

/p done requirements are missing and incorrect

Open
#4,039 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Requires Testing
Dominant language
Java
Stars
653
Forks
975
Avg merge
2m
Merged PRs (30d)
6

Description

Server Implementation

Paper

Server Version

1.19.3

Describe the bug

Given someone wants to add requirements to use the /p done command.

Firstly no settings are loaded from the config for done requirements. The Settings.AUTO_CLEAR config never has done entry

If a plugin adds the done requirements to the settings. When someone uses /p done, the threshold is incorrectly used. A simple empty plot can be marked as done and a complex plot reports as too simple. As shown in the picture

To Reproduce

My done requirements, loaded via a custom plugin

  1. Load "done" requirements into Settings.AUTO_CLEAR. This is not done via the Settings.class, I made a plugin do this.
  2. Select the whole plot with the wand and run //set #perlin[10][emerald_block,gold_block,diamond_block,coal_block,air] or any similar command to generate a lot of variety.
  3. Run /p done on the complex plot, the response is "This plot is too simple. ...". Run /p done on a fresh claimed plot, the response is "Successfully marked this plot as done"
done:
  days: 1
  threshold: 1
  calibration:
    changes: 0
    faces: 0
    data: 0
    air: 0
    variety: 0
    changes_sd: 1
    data_sd: 0
    air_sd: 0
    variety_sd: 0
Expected behaviour

A simple plot does not get set as done. A complex plot should be able to be marked as done

Screenshots / Videos

image

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/60719e8dc66447c491cb9f09aa907450

PlotSquared Version

6.11.1-Premium

Checklist
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the /p done command and the Settings.AUTO_CLEAR configuration, including why the done entry is not loaded and how its threshold is evaluated. Reproduce the reported cases with the supplied requirements and plot debugpaste; done should reject a simple plot while accepting a sufficiently complex one.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.