IntellectualSites / IntellectualSites/PlotSquared

Is LightCleaner still necessary?

Open
#3,514 19 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Approved
Dominant language
Java
Stars
653
Forks
975
Avg merge
2m
Merged PRs (30d)
6

Description

Server Implementation

Paper

Server Version

1.16.5

Describe the bug

When generating new chunks with a custom template that includes lighting-blocks, the lighting is not updated after the chunk is placed the first time. Instead LightCleaner was advertised in the past.

The problem is, that LightCleaner goes into an infinite loop of calculating light for unloaded chunks and this is costing a lot of performance. The author of that plugin said, that the problem relies elsewhere and it is not his fault, so I wonder where this problem comes from.

To Reproduce
  1. Use Template with lighting blocks, for example 'Bridge.template'
  2. Generate Chunks
  3. See no lighting
Expected behaviour

PlotSquared should handle the lighting itself.

Screenshots / Videos

No response

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/ca36ed467388451b9ef4e047cf52e247

PlotSquared Version

PlotSquared version 6.3.0

Checklist
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Plot Debugpaste and reproducing the issue with the Bridge.template on PlotSquared 6.3.0 and Paper 1.16.5. Trace chunk placement and lighting updates for lighting blocks, then compare the behavior with and without LightCleaner. Done means newly generated chunks receive correct lighting without an infinite loop or major performance cost.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.