IntellectualSites / IntellectualSites/PlotSquared
Is LightCleaner still necessary?
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 653
- Forks
- 975
- Avg merge
- 2m
- Merged PRs (30d)
- 6
Description
Server Implementation
Paper
Server Version
1.16.5
Describe the bug
When generating new chunks with a custom template that includes lighting-blocks, the lighting is not updated after the chunk is placed the first time. Instead LightCleaner was advertised in the past.
The problem is, that LightCleaner goes into an infinite loop of calculating light for unloaded chunks and this is costing a lot of performance. The author of that plugin said, that the problem relies elsewhere and it is not his fault, so I wonder where this problem comes from.
To Reproduce
- Use Template with lighting blocks, for example 'Bridge.template'
- Generate Chunks
- See no lighting
Expected behaviour
PlotSquared should handle the lighting itself.
Screenshots / Videos
No response
Error log (if applicable)
No response
Plot Debugpaste
https://athion.net/ISPaster/paste/view/ca36ed467388451b9ef4e047cf52e247
PlotSquared Version
PlotSquared version 6.3.0
Checklist
- I have included a Plot debugpaste.
- I am using the newest build from https://www.spigotmc.org/resources/77506/ and the issue still persists.
Anything else?
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Plot Debugpaste and reproducing the issue with the Bridge.template on PlotSquared 6.3.0 and Paper 1.16.5. Trace chunk placement and lighting updates for lighting blocks, then compare the behavior with and without LightCleaner. Done means newly generated chunks receive correct lighting without an infinite loop or major performance cost.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100