IntellectualSites / IntellectualSites/PlotSquared

Notify the actor if they attempt to merge plots with other player but don't have a high enough plot limit set

Open
#3,218 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement
Dominant language
Java
Stars
653
Forks
975
Avg merge
2m
Merged PRs (30d)
6

Description

Server Implementation

Paper

Server Version

1.17.1

Describe the bug

Merging another plot via a merge request will say it was successfull, but it won't actually do it.

To Reproduce
  1. get to plots with different owners
  2. send a merge request from one plot to another and accept it with the other account.
  3. The chat will send a succes message, but the plots won't actually merge
Permissions used (both accounts):
  • plots.merge
  • plots.plot.*
  • fawe.permpack.basic
  • fawe.plotsquared.member
  • plots.permpack.basic
  • plots.permpack.basicflags
Expected behaviour

The plots actually merging and not just saying they will.

Screenshots / Videos

No response

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/c21a5750daa14e1885c0829adca34f95

PlotSquared Version

PlotSquared version 6.0.9-Premium

Checklist
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the merge-request flow on Paper 1.17.1 with PlotSquared 6.0.9-Premium, using the supplied debugpaste and permissions. Trace the merge-request acceptance path and the plot-limit check. Done means an actor without a sufficient plot limit is notified instead of receiving a success message while the plots remain unmerged.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.